Ryan Kienstra

Results 131 comments of Ryan Kienstra

This is on hold, per https://github.com/ampproject/amp-wp/issues/1626#issuecomment-589365559

Hi @westonruter, >I think these would work well as toggles in an submenu item of the AMP admin bar menu item, if the user has the capability to use them....

Ah, the [commit above](https://github.com/ampproject/amp-wp/pull/3448/commits/e738bcfcb568cf5786d96fb68c6b3ed78f691a86) needs reworking.

Hi @swissspidy, >Should the query vars be prefixed to not cause conflicts with other plugins? Good question. https://github.com/ampproject/amp-wp/pull/3448/commits/19363fc23939a38173ecfe0bd4d4baad3de2583a adds an [amp_flags](https://github.com/ampproject/amp-wp/pull/3448/commits/19363fc23939a38173ecfe0bd4d4baad3de2583a#diff-2585472f207548f626a43a7ff3cab922R103) query var, to access these query vars like: `https://loc.test/your-post/?amp&amp_flags[reject_all_errors]`...

The UI for these query vars still needs a lot of work, but here's its current state: ![query-vars-debugging](https://user-images.githubusercontent.com/4063887/66791638-ad47c380-eeba-11e9-8490-611f87112a14.gif)

Hi @westonruter, that's a really good idea. It'll make this much simpler.

Here's the PHP-rendered submenu. Each node, like 'Disable post-processing', is a link to the AMP URL with that query var.

>There will be a need to set the font-family explicitly to prevent the first one from being rendered as an emoji. So it can be wrapped in a span. Also,...

Hi @schlessera, That's a really good idea to use `AMP_Debug`, preventing the logic from being mixed into several classes.

With https://github.com/ampproject/amp-wp/pull/3448/commits/996157a242412354099945d448d5a17b72f10b1a, the behavior of the debugging query vars is a little different. For example, here are the return values of `AMP_Debug::has_flag( 'reject_all_errors' )`: ## True `&amp_flags[reject_all_errors]` (no value) `&amp_flags[reject_all_errors]=true`...