Ryan Kienstra comments

Results 131 comments of


                                            Ryan Kienstra

QA: Yes, I do "Want to see how it's done"

Your report was very descriptive.

QA: Yes, I do "Want to see how it's done"

Thanks for letting us know 😄

QA: Yes, I do "Want to see how it's done"

I still need to backport https://github.com/studiopress/genesis-custom-blocks/pull/23 into Block Lab.

QA: Yes, I do "Want to see how it's done"

Thanks a lot for reporting this.

No warning on saving new block if mismatched types

Hi @webstationhq, Thanks a lot for bringing this up, and for your great steps to reproduce. I've also seen this. I'll look at this in more detail, you're right that...

Implement block specific scripts similar to stylesheets

Hi @cameronjonesweb, Thanks a lot for bringing this up, and for the details. We'll think about this 😄

Implement block specific scripts similar to stylesheets

This could be a really useful idea, enqueuing JS for blocks. My only concern might be performance. I should do another PHP [profiling test](https://github.com/getblocklab/block-lab/issues/485) to see the cost of this....

Implement block specific scripts similar to stylesheets

Hi @cameronjonesweb, Thanks a lot for suggesting this. In the meantime, in case you didn't notice it, there's an action where you could enqueue scripts for a block: https://github.com/getblocklab/block-lab/blob/32e71bbbfbd89802a06ba363976d76e0862119fe/php/blocks/class-loader.php#L404 Of...

Filter block_lab_icons broken block with wp 5.3

Hi @gfazioli, Thanks for bringing this up. > 'Your site doesn't include support...' Is there a JS console error or warning when that message appears?

Filter block_lab_icons broken block with wp 5.3

Hi @gfazioli, Hope you're doing great. Is there still an issue when adding that filter? I hope it's working alright, but I'd like to fix it if there's still an...