amp-wp icon indicating copy to clipboard operation
amp-wp copied to clipboard

[WIP] Move eligible `@keyframes` rules to `styel[amp-keyframes]`

Open kienstra opened this issue 5 years ago • 3 comments

Summary

  • When a @keyframes rule has valid properties for the style[amp-custom], this moves it there.

  • Still, this need to be reworked to consider @media queries. If a @keyframes is wrapped in a @media query, it should also be wrapped in it when it's moved to the style[amp-keyframes].

Fixes #1626

Checklist

  • [x] My pull request is addressing an open issue (please create one otherwise).
  • [x] My code is tested and passes existing tests.
  • [x] My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

kienstra avatar Feb 20 '20 17:02 kienstra

Sorry, forgot to open this as a draft, instead of using [WIP].

kienstra avatar Feb 20 '20 17:02 kienstra

This is on hold, per https://github.com/ampproject/amp-wp/issues/1626#issuecomment-589365559

kienstra avatar Apr 01 '20 22:04 kienstra

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Oct 08 '20 23:10 CLAassistant