amp-wp
amp-wp copied to clipboard
[WIP] Move eligible `@keyframes` rules to `styel[amp-keyframes]`
Summary
-
When a
@keyframes
rule has valid properties for thestyle[amp-custom]
, this moves it there. -
Still, this need to be reworked to consider
@media
queries. If a@keyframes
is wrapped in a@media
query, it should also be wrapped in it when it's moved to thestyle[amp-keyframes]
.
Fixes #1626
Checklist
- [x] My pull request is addressing an open issue (please create one otherwise).
- [x] My code is tested and passes existing tests.
- [x] My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).
Sorry, forgot to open this as a draft, instead of using [WIP]
.
This is on hold, per https://github.com/ampproject/amp-wp/issues/1626#issuecomment-589365559
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.