Amir Szekely

Results 139 comments of Amir Szekely

> @kichik how would you plan to handle the `cdkghr:started:` labels with --jitconfig? Seeing as the actual start time baked into those labels has to be _even more jit_ 🌞...

Do you have a sense of what that would look like? What code is going to change on our side and what is it going to expose? I'm not too...

I don't see how we can easily integrate the aws-labs solution. It doesn't appear to have been written with the intention of being a library or easily reusable code. I...

Anything of interest in `/var/log/cfn-cmd.log`, `/var/log/cfn-cmd-init.log` and the output of `dmesg`?

Those logs do not go in CloudWatch. It's strange that the step function completed but the system log doesn't show the `aws stepfunctions send-task-success` call. Whenever I see something like...

Last time I tried to use EC2 Fleet I found this: https://github.com/CloudSnorkel/cdk-github-runners/blob/da6a0c0fc497ccada9fb83cd03d7c0b2b96ffb4c/src/providers/ec2.ts#L379 If you find a good way to get around those issues, I'd be happy to merge a PR...

@cynicaljoy where do you see `UserData` being [overridable](https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_FleetLaunchTemplateOverridesRequest.html)? That's exactly the missing part. That's where we put all the runner configuration.

I don't love creating a new resource for every runner. Combined with the idle reaper, that may cause launch templates to be left behind and reach that 1000 limit. It...

The problem with param store/secrets manager is that we need to be able to spin up multiple instances at the same time. They will override each other.

> Am I looking [in the right place](https://github.com/CloudSnorkel/cdk-github-runners/blob/0fc4be5f4ca524d4fe9f0c5056ff5466c2f89332/src/providers/ec2.ts#L33-L41)? (PowerShell below that too of course). Yes. > I was thinking the workflow would be to create unique secret item (whether Secrets...