Amir Szekely

Results 139 comments of Amir Szekely

I believe each task will get its own IP address.

Not sure what exactly you mean. A new EC2 instance will be created for each job. If you're talking about GitHub's Runner Group feature, it's not supported yet on any...

For sure. I never played with groups before, but they sound useful based on your description. @pharindoko in #472 could also use this, for example.

> ok I`ve seen that we could get the group properties from the webhook queued event: https://docs.github.com/en/[email protected]/webhooks/webhook-events-and-payloads?actionType=queued#workflow_job That's a good point. We shouldn't spawn the runner unless it's going to...

I'd accept a PR for that. Sounds like it won't break anything. And I think that behavior will match our current labels behavior. We will only spin up a runner...

Turns out I can't try out runner groups because it requires an enterprise account. > ok I`ve seen that we could get the group properties from the webhook queued event:...

I believe it should already be copying the provider tags to the EC2 instance. So you should be able to use `cdk.Tags.of(provider).add('tagName', 'tagValue')`. Does that not work? Or do you...

What data would this Lambda need? Requested labels? The entire webhook?

I'll have to think about the best way to enable such a feature request. For now you can use the environment variables already supplied by the actions runner code. `GITHUB_REPOSITORY`,...