Amir Szekely

Results 139 comments of Amir Szekely

I still don't have a good idea of what something like that would look like. For example, one of the big problems is that it can't be generic. Settings tags...

It just occurred to me that assigning the tags before a job is assigned to the runner may result in unexpected results. Especially if you're using organization level registration. There...

How would the auto-tagging Lambda have access to the webhook info needed to properly tag the instance? > it would be nice if you could add organization and repository statically...

Might this information be available in the state machine [log](https://github.com/CloudSnorkel/cdk-github-runners/pull/150)?

Turns out all resources do support tags at deploy time. So we should be able to tag with the provider construct path and its labels. The problem is AWS tags...

Would #582 help? Would it be enough?

> In this case I would even prefer a query to Github once the runner is assigned or as you mentioned self-tag the instance. There was a hook available right...

You should already be able to do it. The following worked for me. ```typescript const builder = Ec2RunnerProvider.imageBuilder(stack, 'builder'); builder.addComponent( RunnerImageComponent.environmentVariables({ ACTIONS_RUNNER_HOOK_JOB_STARTED: '/home/runner/runner-started.sh', }), ); builder.addComponent( RunnerImageComponent.custom({ name: 'Self-tag', commands:...

It might help to pin the runner version to an older one with the `runnerVersion` parameter to the image builder. ```typescript const myBuilder = FargateRunnerProvider.imageBuilder(this, 'image builder', { runnerVersion: RunnerVersion.specific('2.320.0'),...