Pasha Khosravi

Expectation of logical formula over a probabilistic circuits

1

1. Given Logical Formula, and a psdd (pc, vtree) 2. Compile it to a smooth logical circuit with the same vtree 3. Compute Expectation of logical circuit w.r.t. the pc....

Having multiple distribution type for inputs fails gpu kernels due to Union split limiation. Currently, can have at most 3 types in the Union of a CuArray for cuda kernels....

- [ ] Param Learning - [x] EM - [ ] EM CPU - [ ] Regurlarization (Softness) - [ ] SGD version. Best option seems to be to customize...

Benchmark common queries on few different circuit sizes, batch sizes, and cpu vs gpu, etc. - Circuit Size [track nodes, edges, layers in bitcircuit] - Batch size (when releveant) [1,...

1. Easy CON API Currently user has to manually call MAR twice to get conditionals. Have some api like this: ``` conditional(circuit::ProbCircuit, data::DataFrame, q_indices) ``` Where `q_indice`s give indexes of...

Match the code of `prob_equiv_signature` with the theory of probabilistic equivalence checking

1

https://github.com/Juice-jl/LogicCircuits.jl/blob/a8f9474e8c668607afbe1e3ab9ab8c2c233292f1/src/Logical/Queries.jl#L40

Bug in `model_count` after conjoin of non-smooth and using `Lit(2)`

1

This should hold for model_count but it does not: mc(delta | x_1) + mc(delta | not x_1) = mc(delta) The issue imight be because of conjoin on non-smooth circuits.

Add condition operation and forgetting

4

1. Condition might be slightly different than what we have implemented. Maybe rename to something like conjoin_literals. 2. In what cases this is possible? I get error when trying it...

This was the removed tests. Currently cannot load logic circuit from psdd files, so would need to go around that (find a sdd to test this on or move the...

Related to: https://github.com/Juice-jl/LogicCircuits.jl/pull/90 `reduce!`, `restrict`, `shannon`, `eliminate`, `marginalize`, `mentions`, `print_nf`, `normal_form`, `atmost`, `atleast`, `exactly`, `forget`.