LogicCircuits.jl icon indicating copy to clipboard operation
LogicCircuits.jl copied to clipboard

Add condition operation and forgetting

Open khosravipasha opened this issue 3 years ago • 4 comments

  1. Condition might be slightly different than what we have implemented. Maybe rename to something like conjoin_literals.

  2. In what cases this is possible? I get error when trying it on Sdds.

khosravipasha avatar Mar 18 '21 06:03 khosravipasha

The naming issue was resolved in https://github.com/Juice-jl/LogicCircuits.jl/commit/e92c417386f4b3a9089c1302148d30cbe82c6951 where condition is now conjoin in the transformations. We should still consider adding a condition operation though, and a forgetting one -- leaving this issue open.

guyvdbroeck avatar Mar 23 '21 06:03 guyvdbroeck

What was the main difference with condition vs conjoin? Would be a nice example in the docs. We already have forgetting, but maybe not for all types of circuit.

khosravipasha avatar Mar 23 '21 19:03 khosravipasha

The function after conditioning on X no longer depends on X. The function after conjoining with X still depends on it and fixes it to one value.

guyvdbroeck avatar Mar 23 '21 21:03 guyvdbroeck

renamed since original issue was resolved and other new things were suggested.

khosravipasha avatar Nov 04 '21 04:11 khosravipasha