khiroshi-win

Results 9 comments of khiroshi-win

I already working on this ticket. but I am working on [this](https://github.com/route06/liam-internal/issues/4741) ticket as well. in this ticket team asked me to update the Table Counter. So I think if...

> @khiroshi-win I found a screenshot of an earlier version that showed the number of tables in the lower left corner🙏 > > ![ss 3313](https://private-user-images.githubusercontent.com/23717638/445008991-6891f863-953e-4830-8fed-de103c40cba8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDc2MzgzMzYsIm5iZiI6MTc0NzYzODAzNiwicGF0aCI6Ii8yMzcxNzYzOC80NDUwMDg5OTEtNjg5MWY4NjMtOTUzZS00ODMwLThmZWQtZGUxMDNjNDBjYmE4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA1MTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNTE5VDA3MDAzNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTk0YzMxOTMwYjQ5MjJjMDc2ZDgzNzlhZTQxMDg1MDZkNzZkZmEyMTZkM2I2ZDU2NzM0NzA5MjRlMDMxM2IwN2EmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.HTY8HGUwfdZBxw9Fjqee-Ot8emct66PIdodoo3dKkHU) Okay, so I guess I...

> @khiroshi-win Oh, wait. It was correct in that position on mobile, and on desktop it was correct in the lower left corner🙏🙏 > > Mobile desktop > ![ss 3314](https://private-user-images.githubusercontent.com/23717638/445017151-81779a45-6383-4f4a-8dcc-778956403bc1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDc2Mzk3MjgsIm5iZiI6MTc0NzYzOTQyOCwicGF0aCI6Ii8yMzcxNzYzOC80NDUwMTcxNTEtODE3NzlhNDUtNjM4My00ZjRhLThkY2MtNzc4OTU2NDAzYmMxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA1MTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNTE5VDA3MjM0OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA0NDhkMWZhNDdlNjc5MmE3MTcyYWFlOTg2OTEwZGJkNTg4ZWY2NGRlOGYwMjk0YjJkY2QyOTA3NGM3ODk5NWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.GhCZ0I5hJ8V1NSu4zwFGQLDluQchXA62NI8h9iakeX8)...

> @khiroshi-win Thanks, am I correct in my understanding that this PR is no longer needed? ref: #1678 Yes this PR is no longer needed.

@MH4GF I have passed all CI testing. Please review this PR if you have a time.

> 💭 It may be more efficient to calculate during rendering using useRef instead of calculating at hover. I'll try to write some sample code. Just moment. let me update...

@MH4GF I don't know why [Supabase Preview](https://github.com/liam-hq/liam/pull/1786/checks?check_run_id=43507336085) always fails on my PR. After merging it from the main branch, I can't get this CI test to pass.

Could you please tell me what colors I can add to `--primary-accent-overlay-hover` and `--pane-background-active-hover`?

I updated the CSS and it works fine on my end. I pushed the updated code, so please review it again.