liam icon indicating copy to clipboard operation
liam copied to clipboard

fix: TableCounter component hidden in left pane

Open khiroshi-win opened this issue 7 months ago • 9 comments

Issue

https://github.com/liam-hq/liam/issues/1690

  • resolve:

Why is this change needed?

What would you like reviewers to focus on?

Testing Verification

image

What was done

🤖 Generated by PR Agent at 7a4f01dbfea02a76ad6151210268638248addaa8

  • Fixes TableCounter visibility issue in left pane
  • Refactors table count rendering for proper display
  • Ensures table count is no longer obscured

Detailed Changes

Relevant files
Bug fix
LeftPane.tsx
Refactor and fix TableCounter display in left pane             

frontend/packages/erd-core/src/features/erd/components/ERDRenderer/LeftPane/LeftPane.tsx

  • Refactored table count rendering to a single span
  • Removed custom divider and class usage for count
  • Ensured table count is fully visible in the left pane
  • +2/-4     

    Additional Notes


    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • khiroshi-win avatar May 19 '25 06:05 khiroshi-win

    ⚠️ No Changeset found

    Latest commit: 34912e986f2f68b149577d9751bdbed9340229a4

    Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

    This PR includes no changesets

    When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

    Click here to learn what changesets are, and how to add one.

    Click here if you're a maintainer who wants to add a changeset to this PR

    changeset-bot[bot] avatar May 19 '25 06:05 changeset-bot[bot]

    The latest updates on your projects. Learn more about Vercel for Git ↗︎

    Name Status Preview Comments Updated (UTC)
    liam-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2025 6:39am
    liam-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2025 6:39am
    liam-erd-sample ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2025 6:39am
    liam-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2025 6:39am

    vercel[bot] avatar May 19 '25 06:05 vercel[bot]

    Updates to Preview Branch (fix/table-counter-hidden-left-pane) ↗︎

    Deployments Status Updated
    Database Mon, 19 May 2025 06:31:27 UTC
    Services Mon, 19 May 2025 06:31:27 UTC
    APIs Mon, 19 May 2025 06:31:27 UTC

    Tasks are run on every commit but only new migration files are pushed. Close and reopen this PR if you want to apply changes from existing seed or migration files.

    Tasks Status Updated
    Configurations Mon, 19 May 2025 06:31:27 UTC
    Migrations Mon, 19 May 2025 06:31:27 UTC
    Seeding Mon, 19 May 2025 06:31:27 UTC
    Edge Functions Mon, 19 May 2025 06:31:27 UTC

    View logs for this Workflow Run ↗︎. Learn more about Supabase for Git ↗︎.

    supabase[bot] avatar May 19 '25 06:05 supabase[bot]

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🎫 Ticket compliance analysis ✅

    1690 - Fully compliant

    Compliant requirements:

    • Fix the TableCounter component that is hidden/obscured in the left pane • Make the TableCounter component fully visible, showing table count information (visible tables / total tables) • Address styling issues that are causing the component to be cut off or hidden

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Restore missing CSS class

    The table counter was likely moved outside the styling class styles.tableCount,
    causing it to lose its styling. Add back the CSS class to maintain consistent
    styling for the table counter.

    frontend/packages/erd-core/src/features/erd/components/ERDRenderer/LeftPane/LeftPane.tsx [94-96]

    -<span>
    +<span className={styles.tableCount}>
       {visibleCount}/{allCount}
     </span>
    
    • [ ] Apply / Chat <!-- /improve --apply_suggestion=0 -->
    Suggestion importance[1-10]: 6

    __

    Why: The suggestion correctly identifies that the styling class was removed from the table counter, which could affect UI consistency. Restoring the class improves maintainability and visual consistency, but it is not a critical bug fix.

    Low
    • [ ] Update <!-- /improve_multi --more_suggestions=true -->

    @khiroshi-win I found a screenshot of an earlier version that showed the number of tables in the lower left corner🙏

    ss 3313

    FunamaYukina avatar May 19 '25 07:05 FunamaYukina

    @khiroshi-win I found a screenshot of an earlier version that showed the number of tables in the lower left corner🙏

    ss 3313

    Okay, so I guess I don't need to update my code to display the counter at the top of the left pane.

    khiroshi-win avatar May 19 '25 07:05 khiroshi-win

    @khiroshi-win Oh, wait. It was correct in that position on mobile, and on desktop it was correct in the lower left corner🙏🙏

    Mobile desktop
    ss 3314 ss 3315

    FunamaYukina avatar May 19 '25 07:05 FunamaYukina

    @khiroshi-win Oh, wait. It was correct in that position on mobile, and on desktop it was correct in the lower left corner🙏🙏

    Mobile desktop ss 3314 ss 3315

    ah I see. Let me carefully check it on my side and will update more if it is need the update. thank you.

    khiroshi-win avatar May 19 '25 07:05 khiroshi-win

    @khiroshi-win Thanks, am I correct in my understanding that this PR is no longer needed? ref: https://github.com/liam-hq/liam/pull/1678

    MH4GF avatar Jun 03 '25 02:06 MH4GF

    @khiroshi-win Thanks, am I correct in my understanding that this PR is no longer needed? ref: #1678

    Yes this PR is no longer needed.

    khiroshi-win avatar Jun 03 '25 02:06 khiroshi-win

    @khiroshi-win OK, I will close this PR. Thanks!

    MH4GF avatar Jun 03 '25 02:06 MH4GF