Raffi Khatchadourian
Raffi Khatchadourian
It seems odd that the ctor is called twice.
I'm not seeing this problem in https://github.com/wala/ML/pull/101. In that test file, we have `global a`: https://github.com/wala/ML/pull/101/files#diff-2c8dda73fa64da2dbb9c44c62cd2d1de6a17f5b817ec4bf48a5dfb226a6abc14R1-R6 And, in the test code that passes, we are finding `global a`: https://github.com/wala/ML/pull/101/files#diff-ae3dfefeb65bbe798173cc0e8da458306c9b620ef00aa183c592f5c9efd88bdaR58
I think it's more of an enhancement than an issue. The workaround is as follows: ```xml -ea:xyz.abc... ``` I'll have a look.
Looks like there's an [existing assertions test](https://github.com/eclipse-tycho/tycho/blob/0fde42d1731d8084ad8997fc9e232ac51f5574da/tycho-its/projects/surefire.enableAssertions/src/tycho/its/env/EnableAssertionsTest.java#L21). And, here's the corresponding field: https://github.com/eclipse-tycho/tycho/blob/0fde42d1731d8084ad8997fc9e232ac51f5574da/tycho-surefire/tycho-surefire-plugin/src/main/java/org/eclipse/tycho/surefire/AbstractEclipseTestMojo.java#L220-L227
@laeubi What is the desired API change here? How are configuration parameters that optimally take arguments typically handled in Tycho?
I'm also seeing that `args` is a private field that is never assigned outside this class: https://github.com/diffplug/spotless/blob/1ad019da39f8994d5b7ccd86a536678cb38fbdea/lib/src/main/java/com/diffplug/spotless/python/BlackStep.java#L89-L107
Here's an example of one that takes a command-line argument: - https://github.com/diffplug/spotless/blob/1ad019da39f8994d5b7ccd86a536678cb38fbdea/lib/src/main/java/com/diffplug/spotless/cpp/ClangFormatStep.java#L44-L46 - https://github.com/diffplug/spotless/blob/1ad019da39f8994d5b7ccd86a536678cb38fbdea/lib/src/main/java/com/diffplug/spotless/cpp/ClangFormatStep.java#L126-L129
Actually, running `black` from the command-line was very fast even without the flag.
When I run `mvn spotless:apply` on the same code, it's extremely slow.
OK, I fixed the problem by altering my include/exclude tags. Now it's fast without any modifications to spotless: ```diff diff --git a/pom.xml b/pom.xml index 3eee11b8..df773850 100644 --- a/pom.xml +++ b/pom.xml...