Raffi Khatchadourian
Raffi Khatchadourian
Hi @cogmission, > I saw your pull request which increases the test size, and I really appreciate your effort on this, but I think inserting this will be a more...
@cogmission, > Also, to contribute to this project you will need to fill out the Contributor's License and @rhyolight will have to do some administrative processing of it after you've...
@cogmission: > Thank you very much for your interest and effort! Thank you for considering the request! > Please have a look at the issue #538 because I've identified what...
I should also note that this test was run on 8 cores.
OK, I've reverted the changes to the columns, which results in the following patch: ```diff diff --git a/src/jmh/java/org/numenta/nupic/benchmarks/AbstractAlgorithmBenchmark.java b/src/jmh/java/org/numenta/nupic/benchmarks/AbstractAlgorithmBenchmark.java index 8a81d171d..74c422dcb 100644 --- a/src/jmh/java/org/numenta/nupic/benchmarks/AbstractAlgorithmBenchmark.java +++ b/src/jmh/java/org/numenta/nupic/benchmarks/AbstractAlgorithmBenchmark.java @@ -47,7 +47,7 @@...
Hi @cogmission, > Ah I see. Hmmm... Well if that's the case then why do we want to change the parameters of the test at all (other than the changes...
Hi all. Does anyone happen to know why GitHub is saying that I haven't signed the contributor license when I have? I believe that this PR should be passing. Thanks!
Thank you @cogmission and @rhyolight! Just to reiterate, the only suggested changes are found in https://github.com/numenta/htm.java/pull/539/files. It is not necessary to change the tests, they were just augmented to exploit...
No problem, @cogmission. Thanks for the consideration and enjoy your vacation!
FYI, I noticed an error in the "Avg" column for the average speedup in the table listed in https://github.com/numenta/htm.java/pull/539#issuecomment-375390517. It should be 1.552094295. I've updated it accordingly. Sorry about that.