Raffi Khatchadourian

Results 148 comments of Raffi Khatchadourian

Maybe we need a new XML tag; something like `create_trampoline=true`. That tag could be attached to the class or the ctor?

I wonder if this creates a trampoline: https://github.com/wala/ML/blob/ddba21e7881f2a9cc825f1857aea5a5ea89f1bc3/com.ibm.wala.cast.python.ml/data/tensorflow.xml#L492-L493

On the example I tried, by removing `if __name__ == `__main__`:`, I am getting four more basic blocks than I had previously. The corresponding call graph node is that of...

Hey @msridhar. How is this supposed to work in Java/Javascript in WALA? Suppose we had the following in contrast to the above examples, where a CHA analysis would work well:...

See https://github.com/wala/ML/blob/master/CONTRIBUTING.md#building.

I can't repo this on 6c85f992fb9de2975af080da684500edfee4f0ad.

> When using junit4 annotations, the static method `make(IClassHierarchy cha)` can not return any entrypoint. > > I found that `isTestEntryPoint(TypeName typeName)` might be wrong: > > ```java > private...

Ah, but that's in `toString()`. If the problem is from `getPackage()`, the package comes from the constructor and can be any atom. I guess different representations may not be prefixed...

The scenario I am thinking of is where a PR was never a draft to begin with. This, "undo" would seem a bit counterintuitive. The edit flag looks good, but...