Khalifa Lame

Results 23 comments of Khalifa Lame

Improvements to existing components that don't introduce any breaking changes don't have to wait for v5.

Now that the styling is being reworked, perhaps we should also consider the following. - fluid typescale for more responsive texts. - CSS @layer-compatible styling to make it much easier...

Being able to optionally use the [Constraint Validation API](https://developer.mozilla.org/en-US/docs/Web/API/Constraint_validation) for form validations would be nice to have. At this point, I think the current way of presenting form field errors...

`RcRangePicker` does not apply the aria attributes to its underlying `input` elements. That will probably need to be addressed on that library.

Snapshot tests are failing despite having updated the snapshots with `npm run test:update`. Any ideas?

> ci failed @afc163 the failure appears to be because of some outdated snapshots. But even after updating the snapshots with `test:update`, the ci still fails. Any clues what I...

Anything more I need to do to get this reviewed?

Sure. here's an example https://codesandbox.io/s/hungry-pond-hildoh?file=/src/App.js

That's an option, but it goes beyond just validation. Each subform can be independently submitted or reset. And for the sake of accessibility, each subform may need to have its...

Seems to be a common issue with components that have partial overlays. The Popover, also has this issue.