Keegan Campbell

Results 223 comments of Keegan Campbell
trafficstars

@boredland you're certainly welcome to take this code as it is, resolve the issues/conflicts, and submit as another PR! I'd be happy to review it should you decide to do...

My guess is this is related to #2133 in which we're checking and returning an error that was previously ignored. This could be a good first issue for a new...

Sorry for the delay here. After the addition in `TestAccGithubBranchProtectionV3_required_pull_request_reviews`, the acceptance tests are failing: ``` testing.go:705: Step 0 error: Check failed: 1 error occurred: * Check 5/12 error: github_branch_protection_v3.test:...

@georgekaz you're a hero for fighting the good fight with our test situation. Thanks for your research! As always, should you desire to submit any PRs with fixes you'd like...

@isaacsanders I think the next best step would be to handle migrations for this breaking change gracefully. We've got some prior art on state migration [here](https://github.com/integrations/terraform-provider-github/blob/main/github/resource_github_repository.go#L31). I'm sure there's Hashicorp...

Looks like it, thanks!

@isaacsanders we're planning on cutting a new major version in the near future. Do you have the interest/inclination to continue this work so we can get it merged? If not,...

@laurenty Ideally we'd do that and at the same time provide a separate resource for managing pages for a repository. I'd like to avoid deprecation without an alternative in place.

Ahh, my mistake! Thank you for correcting me; that's a great course of action.

@wparr-circle do you mind explaining more about the below part of your writeup? I'm not sure I understand, sorry. > where we manipulate a commit and push it to the...