Keegan Campbell

Results 289 comments of Keegan Campbell

For an example of this running successfully, see [this Actions run](https://github.com/octokit/source-generator/actions/runs/7108085802) that generated [this PR](https://github.com/octokit/go-sdk/pull/16).

@jamestelfer no worries at all, we appreciate and welcome the thoughtfulness! Let's discuss a little further if that's okay since I'm not quite sure I have a handle on what...

> I was going to contribute that to ghinstallation. Given that the two are interchangeable, I'm looking to change the internal representation of the ID to a string, and allow...

> would it be an opportunity to consider breaking API changes, or ease transition by keeping the original API? For our purposes, I'm okay with breaking changes (and I did...

Hi! That's an artifact of the generation tooling we use, [Kiota](https://github.com/microsoft/kiota). You'd have to ask over there to be sure. My _guess_ is that they do it because hashes are...

> Some times a graphql response fields have value null. Are you saying this is intended behavior and not an API issue?

This is interesting! GitHub returns a 302 that redirects to the actual content. That 302 (and the type of the actual content) isn't getting picked up at generation time. Kiota...

I've filed https://github.com/microsoft/kiota/issues/5208 with Kiota to double-check, but I believe this is a spec issue: we shouldn't be showing the redirect as a response in the spec, and instead we...

@MatisseHack Ooh, I should probably swap over. I used the library I did because I was going off of the [Octokit docs](https://github.com/octokit/octokit.net/blob/main/docs/github-apps.md#a-note-on-jwt-tokens) :grimacing:; perhaps we should change those as well?

I appreciate this super thoughtful bug report, and thank you for working to bring the new SDK into the Terraform provider. That's great! I've reproduced what you've done here on...