Keegan Campbell

Results 273 comments of Keegan Campbell

The naive, quick thing to do would be to replace ```go if err = d.Set("id", runnerGroup.GetID()); err != nil { return err } ``` with ```go _ = d.Set("id", runnerGroup.GetID())...

When running the new integration tests, I get the following error: ``` resource_github_actions_enterprise_permissions_test.go:261: Step 1/1 error: Error running pre-apply refresh: exit status 1 Error: Could not resolve to a Business...

@laughedelic good catch. I have a slight preference for `github_enterprise_actions...` since these are settings that only exist in enterprise, though I'd be happy to hear arguments either way.

I'm not sure if this has API support to be actionable in the first place. The closest thing I can find is [here](https://docs.github.com/en/rest/dependabot/alerts?apiVersion=2022-11-28#update-a-dependabot-alert), which requires granting access first via the...

Thank you for picking this up! I like the approach for calculating owner and taking the explicit one (if given) first. > I'm looking for feedback on the adjustments /...

Thank you for the thoughtful response! > I'm curious if any of those approaches seems better to you than my current one (a new, explicit environment variable for the owner...

Thanks @avidspartan1! I'm seeing errors on the newly added tests when I run: ``` testing.go:705: Step 1 error: Check failed: Check 1/1 error: github_repository.test: Attribute 'primary_language' expected "Go", got ""...

@avidspartan1 apologies for the delay. My main concern here is around testing, I was struggling to make the new integration tests pass: ``` --- FAIL: TestAccGithubRepositories/creates_and_updates_repositories_with_owner_without_error (0.91s) --- FAIL: TestAccGithubRepositories/creates_and_updates_repositories_with_owner_without_error/with_a_unique_resource-specific_owner...

Thank you @pascal-hofmann! Do you mind helping me run these tests? They're passing for me on the main branch but failing on this branch with a `Error: PATCH https://api.github.com/repos/kfcampbell-terraform-provider/tf-acc-test-pub-vuln-3xaws: 422...