terraform-provider-github
terraform-provider-github copied to clipboard
feat: Add allow_forking to github_repository
Resolves #1071
Additional info
Pull request checklist
- [x] Tests for the changes have been added (for bug fixes / features)
- [x] Docs have been reviewed and added / updated if needed (for bug fixes / features)
- [ ] Added the appropriate label for the given change -> No permissions to add labels. :(
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
- [ ] Yes (Please add the
Type: Breaking changelabel) - [X] No. There have been issues with this in the past, but this should not be an issue when defaulting to
false(this is also the default stated in the REST API docs.
Pull request type
- Feature/model/API additions:
Type: Feature
Thank you @pascal-hofmann! Do you mind helping me run these tests? They're passing for me on the main branch but failing on this branch with a Error: PATCH https://api.github.com/repos/kfcampbell-terraform-provider/tf-acc-test-pub-vuln-3xaws: 422 This organization does not allow private repository forking [] error. That's weird to me, since my repository has private forking enabled everywhere:

Does it pass for you?
@kfcampbell No, it does not. :(
No idea what's wrong here…
Any chance of getting this merged?
is it forgotten?
I've just rebased this PR and resolved the conflicts.
Is there anything it can be done to push this forward? In highly automated environments as ours, and trying to push innersourcing internally, this is a bump on the road. Let us know if there's something we can do to help you on this.
Thanks! 🙏
Hey, what is blocking this PR? We'd love to have it.