terraform-provider-github icon indicating copy to clipboard operation
terraform-provider-github copied to clipboard

feat: Add allow_forking to github_repository

Open pascal-hofmann opened this issue 2 years ago • 11 comments

Resolves #1071


Additional info

Pull request checklist

  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • [ ] Added the appropriate label for the given change -> No permissions to add labels. :(

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

Pull request type

  • Feature/model/API additions: Type: Feature

pascal-hofmann avatar Apr 13 '23 08:04 pascal-hofmann

Thank you @pascal-hofmann! Do you mind helping me run these tests? They're passing for me on the main branch but failing on this branch with a Error: PATCH https://api.github.com/repos/kfcampbell-terraform-provider/tf-acc-test-pub-vuln-3xaws: 422 This organization does not allow private repository forking [] error. That's weird to me, since my repository has private forking enabled everywhere:

image

Does it pass for you?

kfcampbell avatar Apr 14 '23 21:04 kfcampbell

@kfcampbell No, it does not. :(

No idea what's wrong here…

pascal-hofmann avatar Apr 17 '23 18:04 pascal-hofmann

Any chance of getting this merged?

sergiuciudin avatar Jan 08 '24 13:01 sergiuciudin

is it forgotten?

yaroslav-nakonechnikov avatar Mar 05 '24 08:03 yaroslav-nakonechnikov

I've just rebased this PR and resolved the conflicts.

pascal-hofmann avatar Mar 05 '24 08:03 pascal-hofmann

Is there anything it can be done to push this forward? In highly automated environments as ours, and trying to push innersourcing internally, this is a bump on the road. Let us know if there's something we can do to help you on this.

Thanks! 🙏

glerchundi avatar Apr 08 '24 12:04 glerchundi

Hey, what is blocking this PR? We'd love to have it.

harpunius avatar Apr 25 '24 09:04 harpunius