Kevin Herron
Kevin Herron
Hey Marcus, It looks like you have an ECA on file for [email protected] but you've authored this commit with your Emerson email address.
Thanks Marcus, this looks really good on the surface. I'm going to check it out and take a closer look sometime today. I might try to build a transfer example...
I want to see if I can piggy back on this to add a "local" transfer API as well. That way there's an easy to use transfer for when you're...
@marcus-orchard do you mind if I start pushing some minor changes to this PR as I review?
I'll make the changes, I've got it open right now. I've intentionally not opted into Java's broken serialization system (and gone towards immutable objects with final fields), so no-arg constructors...
I like the "trick" where you call modify when "transferring" monitored items to make sure you have current values for all the revised fields. I'm wondering if that same trick...
I get what you're saying. I forgot that you don't even have subscription ids as the client taking over. An overload might not be a bad idea, I'll think about...
@marcus-orchard what do you think about taking the `transferMonitoredItems` methods off of the `UaSubscription` interface and just giving them local visibility in OpcUaSubscription? Is there some scenario where a user...
TODO: my local transfer implementation is still slightly broken because it doesn't offer the caller a chance to hook up monitored item event and value callbacks before the notification semaphore...