Kevin Herron

I'll need some time to familiarize myself with Part 12 again before I can review this in meaningful detail. After a cursory glance though, a couple things occur to me:...

> I would suggest adding a boolean to OpcUaServerConfig to enable/disable the new discovery services. Good to go? That might work. After thinking about it more it might help if...

Ok all sounds reasonable so far 👍 At some point you might rebase or cherry pick from master, I made the existing FindServers implementation a little better in https://github.com/eclipse/milo/commit/492580186fb730c516fb83f56a4be61ecbe204d1

Heads up: sometime this weekend I'm being forced to rewrite history in master. Once that happens you'll need to fetch and reset master in your fork and then rebase this...

Eclipse Foundation is forcing me to do it. I've already lost the appeal. Believe me, this is not my choice. Legal bureaucracy... 😞 At some point in history I accidentally...

As you can see by the collateral damage to this PR, the rewrite has taken place. You'll need to rebase your changes and rewrite the history of your fork and...

I'll take a closer look this weekend, but some superficial stuff I see: - Continuation indents should be 4 spaces if your editor is configurable in that manner. Checkstyle isn't...

Just wanted to let you know I haven't forgotten about this! I'm just a little pre-occupied trying to get a bunch of work on DataTypes and encoding done for 0.2.0....

The only thing I remember seeing was the issue of whether or not it can shutdown and startup again cleanly within a continually running JVM/env (no standalone threads etc...). I'll...

Oh, also Travis CI seems to be unhappy about something... edit: Maybe the certificate is expired? I updated the certificate on the master branch somewhat recently.