Ronan Keryell

Lecture_05_Device_Discovery starts with too many details

1

The section dives directly in a lot of gory details. I wonder whether it would not be more palatable to just talk about the default device selectors and from there...

Update device selector style to follow modern SYCL 2020

1

There is still a lot of deprecated SYCL 1.2.1 device selector usage. This is a follow-up from https://github.com/codeplaysoftware/syclacademy/pull/72#discussion_r723980895 This is a generalization of https://github.com/codeplaysoftware/syclacademy/issues/54

Lecture_16_Coalesced_Global_Memory cannot be understood without having a concrete architecture

1

There is no hardware description of memory hierarchy and hardware architecture in this part, so it is difficult to understand the problem we are solving here.

Unclear USM categories

1

In `Lesson_Materials/Lecture_7_Introduction_to_USM/index.html` on slide "USM variants" it is unclear where these categories come from and how it relates to the ones we have in SYCL 2020. Is it some left-over...

Mainly using a part for Vitis IP which is installed by default.

There are still some xocc and XOCC in sycl/test/lit.cfg.py

1

Check for old stuff in `sycl/test/lit.cfg.py`.

Update documentation to new test infrastructure

1

**Describe the bug** https://github.com/triSYCL/sycl/blob/sycl/unified/next/sycl/doc/GettingStartedXilinxFPGA.md should be updated around **Running the test suite**

Do not generate DDR bank by default if there is no DDR but HBM

5

I have tried the tool-chain on an Alveo U50 (with HBM memory :-) ) according to the documentation with: ```bash export XILINX_PLATFORM=xilinx_u50_gen3x16_xdma_201920_3 $SYCL_BIN_DIR/clang++ -std=c++20 -fsycl -fsycl-targets=fpga64_hls_hw_emu single_task_vector_add.cpp -o single_task_vector_add ```...

Simplify difference in `clang/test/CodeGenSYCL/loop_unroll.cpp`

1

I have the feeling that the change at the beginning of should not exist in https://github.com/triSYCL/sycl/compare/8677d5d562bb..6c7fac3aeb6#diff-4decc3bd7c76c920f705a179987a922f7d54b86636121a2cbb4441a7d6ace291