Ronan Keryell

When looking at https://github.com/ORNL/cpp-proposals-pub/tree/master/P0009 directory it is not obvious that the reference implementation there is no longer the one to use but https://github.com/kokkos/mdspan instead. Yes, this is described in the...

Fix syntax errors in some pre-removal and post-installation scripts

6

This was introduced with commit 2b870279f68f7f2b3d08315b7269acbdc1c6033c from https://github.com/Xilinx/XRT/pull/8008

std::pair has .first and .second

1

And not .begin and .end.

Should we increment the revision of the document, since it has been already submitted to the ISO C++ committee?

How to use ClangIR downstream?

4

Hi! I am trying to use this project as a C++ frontend for another MLIR project but I struggle to have my other project to compile because the MLIR common...

A menu is unusable when there are too many items in it

5

When a menu is to large to fit on the screen it is not possible to select items outside of what is shown on the screen. This happens typically on...

XRT uses https://github.com/Tencent/rapidjson to parse JSON files but this is an archaic C++ which is mostly unchanged since 2016. Compiling XRT leads to ``` In file included from /home/rkeryell/Xilinx/Projects/AIE/xdna-driver/xrt/src/runtime_src/tools/xclbinutil/RapidJsonUtilities.h:24, from...

It looks like the current `std::variant` use causes some HLS breakage https://jira.xilinx.com/browse/CR-1093830 Not super clear which workaround can be used. This probably requires to start from a minimal version of...

+50% slow down

9

I have a slowdown on the recent version of the `path_tracer` on my CPU laptop. If you notice the same, can you bisect the change? Perhaps some objects we copy...

There are a few superfluous `.data()` and `get_pointer()` instead of just using the `accessor`. For example instead of ```c++ render(myQueue, fb.data(), hittables.data(), hittables.size(), cam); save_image(fb.data()); ``` ```c++ render(myQueue, fb, hittables,...