Kerry Jones
Kerry Jones
I found the same issue and ended up creating a patched version of ex_aws that supports it. Here's my patch for it: https://github.com/blendmedia/ex_aws_s3/commit/2836ec97e8a654fe75e55082e29e00452806f04f Just had a look at the latest...
I've been using this patch in production since Feb 2019. Looking at it again now because I'd quite like to move back to using the official version of ex_aws and...
Not sure why I didn't submit this PR at the time I created this. This fixes the issue mentioned in #46 where the upload_id and part_number are required by S3...
This PR also fixes #75 because `ExAws.S3.Parsers.parse_complete_multipart_upload` is now doing what was done in `ExAws.S3.Parsers.parse_upload` and from what I can see `ExAws.S3.Parsers.parse_upload` isn't used and can be deleted.
Yeah good question about the tests. I have a much simpler implementation of the encoding now that encodes both in the build() method. It works for the tests currently in...
Sorry I haven't forgotten about trying to get better test coverage in here. I've just ended up with crunch time at work. I'll hopefully get a chance to add some...
Here's the PR #704 I think this fixes the issue. Let me know what you think and if there's something I've missed here in terms of how these methods are...
@rmayhue Yes, I'm using PR #704 in production, because this is a real bug in the main repo and I can't work with out.
Good to hear. I'm going to aim to get back to the PR this weekend and see if I can find some info that would help with adding some new...