ex_aws_s3 icon indicating copy to clipboard operation
ex_aws_s3 copied to clipboard

Adds multipart copy support

Open kerryjj opened this issue 3 years ago • 3 comments

This PR sends the required upload_id and part_number to upload_part_copy and implements the parsing of the responses required to make multipart copy work.

See the spec here https://docs.aws.amazon.com/AmazonS3/latest/API/mpUploadUploadPartCopy.html

kerryjj avatar Apr 10 '21 05:04 kerryjj

Not sure why I didn't submit this PR at the time I created this.

This fixes the issue mentioned in #46 where the upload_id and part_number are required by S3 and when calling AWS.S3.upload_part_copy.

We also weren't parsing the responses for upload part copy, so I've done that and the feature now works.

kerryjj avatar Apr 10 '21 06:04 kerryjj

This PR also fixes #75 because ExAws.S3.Parsers.parse_complete_multipart_upload is now doing what was done in ExAws.S3.Parsers.parse_upload and from what I can see ExAws.S3.Parsers.parse_upload isn't used and can be deleted.

kerryjj avatar Apr 10 '21 06:04 kerryjj

Hi @kerryjj - thanks very much for the patch (and especially for including tests - those always make me feel more confident about changes), and my apologies for not getting to it sooner. Would you be kind enough to resolve the conflicts with the current master, and then I'll get this merged? Thanks heaps.

bernardd avatar Apr 29 '21 06:04 bernardd

Superseded by #217

bernardd avatar Sep 25 '23 06:09 bernardd