Dariusz Rumiński
Dariusz Rumiński
> What changes would remain? logic changes other than changed ruleset and applied style changes.
it's massive diff change that i do not want to introduce on 3.x line _at all_. it is still OK to merge other part of the code, there is handling...
Thank you for minifying the diff. As I wrote few times, I do not want to apply this change to PhpCsFixer ruleset. (example: https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/pull/8220#discussion_r1799309921) Not sure if you implicitly skipped...
if nobody was interested to develop it for a year, OK to get closed as stale. it doesn't mean feature would get rejected if someone would implement it.
@nesl247 @nathanjanczewski-mi @cavias it would get merged sooner if on top of your interest, you would also conduct a review! but no worry, other PRs are awaiting for your support...
Always like that on the start. it's easier later ;)
change that brings this question: https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/commit/d46dd35170e11d2fba3d9f8b7a3e6057fd924f40#diff-2c4210385b386b8371b68e95ea1ba30a7e276f2d2dbd47d34eda6b2c67d810d6L30-L38 on prd run, if TokenizerLinter is available (which is now always the case), we use it. (otherwise we fallback to ProcessLinter, but no longer...
after https://github.com/getsentry/sentry-javascript/pull/13502 is merged, shall this issue be still open ? cc @Lms24
marking with label, not exactly 8.4, but around it very closely
@nicolas-grekas btw, how OK you would be to have the rule automating final dot for single-sentence too? I understand no value in doing it manually, but it is only inconsistency...