Dariusz Rumiński comments

Results 303 comments of


                                            Dariusz Rumiński

[enhancement] Add missing bower.json.

:+1:

Prove that ScalarComparator doesn't follow ==

I do agree that `==` is sad, but that's how ppl understand equality over identity in PHP, and as you see in referred ticket, ppl were relying on that, sadly....

Prove that ScalarComparator doesn't follow ==

Not necessary, it may, but it may not be a bug. I saw situation when, for example, ppl were taking numeric string from JSON (eg "5.10") and compare it to...

Prove that ScalarComparator doesn't follow ==

but not all JSON producers expose numbers as numbers, eg in python2. but that's just an example. other is retrieving values from DB without type correction, other is any intentional...

Allow shortenedExport() to use __toString() on objects if defined

idea behind this PR is nice ;)

GitHub for Windows compatibility

looks like really great work here, yet not sure what is the status here. already extra old, any chances to have bats working on Windows ? (probably would be nice...

broken phar release

I am not familiar with phing ( I use `humbug/box`, originally `box-project/box2` ), thus I won't be able to help with phing configuration, yet... stubfile created for phar file is...

processing includes as proposed in #67

btw, squash can be done automatically during merging ;)

fix: Don't fail rendering on stderr warnings

@faressoft , can you kindly consider merging this PR ?

Is there a way to feed a coverage report to Humbug?

I miss that too. Any help here ?