Dariusz Rumiński
Dariusz Rumiński
3.8 was not touching the code, 3.9 started fixing it. Indeed, in a way that you did not expect. Having the "continuation indentation" as a separated setting would mean: -...
While I appreciate the effort you put into this feature, I decided to reject this feature to be merged into the mainline of this project, for now. For now, you...
in future, please try avoid force-pushes, hard to review when you don't know what changed and need to review everything from scratch
OK, I got lost. what's the difference between `'no_whitespace_before_comma_in_array' => true` and `'multiline_whitespace_before_statement_end' => ['comma_strategy' => 'no_new_line', 'semicolon_strategy' => 'none']`
so, from ticket you are closing here, you want to have this as a fixing result (using `new_line_for_chained_calls` option): ```diff $foo ->foo() - ->foo(), + ->foo() + , ``` for...
OK, I found exactly that test. My confusion go higher... `'no_whitespace_before_comma_in_array' => true,` and `'multiline_whitespace_before_statement_end' => ['comma_strategy' => 'no_new_line'],` will do the same for multiline whitespaces.... ?
Would that one, unified rule allow for achieving this? (copy-pasted from itest): ``` --EXPECT--
ping @julienfalque
BC - there is no BC promise yet for new printer we can deprecate existing printer **without** giving one-to-one replacement, we did it on numerous occasions. I totally agree with...
what do you think about my proposal, @julienfalque ?