Kenneth Ma

icon indicating a website link https://kenma.ca icon indicating an email [email protected]

icon company @acv-auctions icon location Toronto, Ontario, Canada icon location Mobile Lead, R&D at @acv-auctions

Results 2 issues of Kenneth Ma

authenticationPrompt does not work in getInternetCredentials

6 comment

It seems like `authenticationPrompt` is only working for `getGenericPassword`, contrary to the docs in `README.md`. We just need to pass in `options[kAuthenticationPromptMessage]` into `(__bridge NSString *)kSecUseOperationPrompt: options[kAuthenticationPromptMessage]` in `RNKeychainManager.m`.

Refactoring Notification preferences

3 comment

Follow up to #1653 and comments around refactoring `_check_cascading_vars` to lift `watch.get('notification_muted')` out into `send_content_changed_notification` instead. I renamed the function and put some time into cleaning up the function itself...