react-native-keychain icon indicating copy to clipboard operation
react-native-keychain copied to clipboard

Published 20 hours ago • verified publisher icon oblador

authenticationPrompt does not work in getInternetCredentials

Open kenmaca opened this issue 6 years ago • 6 comments

It seems like authenticationPrompt is only working for getGenericPassword, contrary to the docs in README.md.

We just need to pass in options[kAuthenticationPromptMessage] into (__bridge NSString *)kSecUseOperationPrompt: options[kAuthenticationPromptMessage] in RNKeychainManager.m.

kenmaca avatar Feb 28 '19 19:02 kenmaca

hi! Thanks for reporting! Please open a PR if you believe we have a bug / feature missing, thanks!

vonovak avatar May 19 '19 22:05 vonovak

https://github.com/oblador/react-native-keychain/pull/471

serbanbjd avatar May 31 '21 10:05 serbanbjd

@vonovak @OleksandrKucherenko @pcoltau This is the pr with the fix for the above situation

serbanbjd avatar May 31 '21 11:05 serbanbjd

@oblador How can we get this approved and merged in the next release? Thank you.

serbanbjd avatar May 31 '21 11:05 serbanbjd

I've pushed a fix for this 2 weeks ago, unfortunately there is no movement in the review processs. I wonder what can I do to move this forward.

serbanbjd avatar Jun 14 '21 05:06 serbanbjd

This has been fixed and merged. @vonovak do you think a fix version can be released? Then we can close this. Thanks

serbanbjd avatar Jun 28 '21 13:06 serbanbjd