Richard B.

Results 94 comments of Richard B.

The carthage copy-framework isn't necessary for framework target, the will have both your dependency and your framework in Carthage/Build directory: ``` ls -1 Carthage/Build/iOS/ |grep -E "pop|Slider" Slider.framework Slider.framework.dSYM pop.framework...

I think c is not a good way because you leave the review process, let's make another proposition : d) by clicking dots displayed instead of line numbers, show 10...

Maybe tuning the number of lines before/after can be made via a parameter in config file ?

A related other enhancement : have file name also kept (useful when reviewing "relatively big" files), but just below the commit message. Maybe it could be a separate issue, because...

My idea was to use this in continuous integration (so server side, headless), just before using https://github.com/nst/objc_dep to make a graph of classes

> > This is what we do for running swiftlint only on modified files (based on git status) > > ``` > > git status --porcelain | grep -v '^...

same issue (trying to update my PR) : ``` git log -1 commit 68abf2d73791720457f5be1aab4b57df86483f88 (HEAD -> master, origin/master, origin/HEAD) [...] $ rm -rf .build/ ; make swift package --skip-update resolve...

``` $ make clean swift package clean swift package reset ✔︎ $ make swift package --skip-update resolve Fetching https://github.com/Carthage/Commandant.git Fetching https://github.com/Quick/Quick.git Fetching https://github.com/jdhealy/PrettyColors.git Fetching https://github.com/thoughtbot/Curry.git Fetching https://github.com/Carthage/ReactiveTask.git Fetching https://github.com/apple/swift-llbuild.git Fetching...

> For clarity, (as I understand it) this allows Carthage to share already built dependencies across projects. > > We have a workspace that has `Y` many targets across many...

Hi, I updated code responding to reviews, and rebased my feature branch on top of current master, after a `make install` on my machine: 3m1.871s for initial `carthage bootstrap`, 0m15.297s...