fluid-slider icon indicating copy to clipboard operation
fluid-slider copied to clipboard

Issue with carthage integration

Open Nainculte opened this issue 5 years ago • 3 comments

Hello I am getting multiple issues with the carthage integration of this project in my app when submitting the app to the AppStore as follows:

App Store Connect Operation Error
CFBundleIdentifier Collision. There is more than one bundle with the CFBundleIdentifier value 'com.facebook.pop' under the iOS application 'MyApp.app'.
App Store Connect Operation Error
Invalid Bundle. The bundle at 'MyApp.app/Frameworks/Slider.framework' contains disallowed nested bundles.
App Store Connect Operation Error
Invalid Bundle. The bundle at 'MyApp.app/Frameworks/Slider.framework' contains disallowed file 'Frameworks'.

I am copying the frameworks using the carthage utilities. So I am wondering what I am doing wrong here. If I don't copy them it just doesn't work.

I am using Xcode 10.2 and Carthage 0.33.0

Nainculte avatar Jun 04 '19 12:06 Nainculte

Hello @Nainculte, I am having the same issue, did you find a fix?

"Error Domain=ITunesTransporterErrorDomain Code=-18000 \"ERROR ITMS-90685: \"CFBundleIdentifier Collision. There is more than one bundle with the CFBundleIdentifier value 'com.facebook.pop' under the iOS application 'RecoShop.app'.\"\" UserInfo={NSLocalizedRecoverySuggestion=ERROR ITMS-90685: \"CFBundleIdentifier Collision. There is more than one bundle with the CFBundleIdentifier value 'com.facebook.pop' under the iOS application 'RecoShop.app'.\", NSLocalizedDescription=ERROR ITMS-90685: \"CFBundleIdentifier Collision. There is more than one bundle with the CFBundleIdentifier value 'com.facebook.pop' under the iOS application 'RecoShop.app'.\", NSLocalizedFailureReason=ERROR ITMS-90685: \"CFBundleIdentifier Collision. There is more than one bundle with the CFBundleIdentifier value 'com.facebook.pop' under the iOS application 'RecoShop.app'.\"}"
"Error Domain=ITunesTransporterErrorDomain Code=-18000 \"ERROR ITMS-90205: \"Invalid Bundle. The bundle at 'RecoShop.app/Frameworks/Slider.framework' contains disallowed nested bundles.\"\" UserInfo={NSLocalizedRecoverySuggestion=ERROR ITMS-90205: \"Invalid Bundle. The bundle at 'RecoShop.app/Frameworks/Slider.framework' contains disallowed nested bundles.\", NSLocalizedDescription=ERROR ITMS-90205: \"Invalid Bundle. The bundle at 'RecoShop.app/Frameworks/Slider.framework' contains disallowed nested bundles.\", NSLocalizedFailureReason=ERROR ITMS-90205: \"Invalid Bundle. The bundle at 'RecoShop.app/Frameworks/Slider.framework' contains disallowed nested bundles.\"}"
"Error Domain=ITunesTransporterErrorDomain Code=-18000 \"ERROR ITMS-90206: \"Invalid Bundle. The bundle at 'RecoShop.app/Frameworks/Slider.framework' contains disallowed file 'Frameworks'.\"\" UserInfo={NSLocalizedRecoverySuggestion=ERROR ITMS-90206: \"Invalid Bundle. The bundle at 'RecoShop.app/Frameworks/Slider.framework' contains disallowed file 'Frameworks'.\", NSLocalizedDescription=ERROR ITMS-90206: \"Invalid Bundle. The bundle at 'RecoShop.app/Frameworks/Slider.framework' contains disallowed file 'Frameworks'.\", NSLocalizedFailureReason=ERROR ITMS-90206: \"Invalid Bundle. The bundle at 'RecoShop.app/Frameworks/Slider.framework' contains disallowed file 'Frameworks'.\"}"

Any idea @RamotionDev ? Are you using Carthage to publish your own demo app including this Slider ?

Drusy avatar Jul 04 '19 12:07 Drusy

A Script Phase rm -r ${BUILT_PRODUCTS_DIR}/${FRAMEWORKS_FOLDER_PATH}/Slider.framework/Frameworks right after the Carthage copy frameworks phase pass the AppStoreConnect validation.

This is only a workaround and would be nice to be fixed in the next release

Drusy avatar Jul 04 '19 13:07 Drusy

The carthage copy-framework isn't necessary for framework target, the will have both your dependency and your framework in Carthage/Build directory:

ls -1 Carthage/Build/iOS/ |grep -E "pop|Slider"
Slider.framework
Slider.framework.dSYM
pop.framework
pop.framework.dSYM

The application will have to copy both framework in their run script build phase

kenji21 avatar Jul 04 '19 13:07 kenji21