codebrag Missing context when reviewing

First, thank you for your nice tool I use to review teammate changes

Second, I open this issue to "discuss" about adding context (I'm not saying that I got a "great" idea, but simply trying to give you some "user" feedback).

During some reviews, I don't have enought "context" : 3 lines before and after a change is sometimes not enought to my point of view. The solution, to my eyes, can be to have a link to see the "whole file diff". What do you think of such a feature ?

Jan 17 '15 21:01 kenji21

It is indeed a good idea. I also wanted to see the full file when reviewing code. The way I manage today is, I already have the workspace checkout in my desk. Usually most of the developers have access to the repository they are working with. For an enterprise user it makes sense to be able to see all the code online. But the question is what all can be reasonably provided. For eg : when the user is looking at the source file , and discovers that it has already changed in ongoing commits he will also want to see the latest change and history. Effectively codebrag will have to perform repository viewer functions. To summarize we have 3 options a) No Change b) Basic support to view the repository and its history, with basic navigation features c) Integrate with existing tools --Kiran

On Sun, Jan 18, 2015 at 2:44 AM, kenji21 [email protected] wrote:

First, thank you for your nice tool I use to review teammate changes

Second, I open this issue to "discuss" about adding context (I'm not saying that I got a "great" idea, but simply trying to give you some "user" feedback).

During some reviews, I don't have enought "context" : 3 lines before and after a change is sometimes not enought to my point of view. The solution, to my eyes, can be to have a link to see the "whole file diff". What do you think of such a feature ?

— Reply to this email directly or view it on GitHub https://github.com/softwaremill/codebrag/issues/23.

Jan 18 '15 07:01 gmkumar2005

I think c is not a good way because you leave the review process, let's make another proposition :

d) by clicking dots displayed instead of line numbers, show 10 (20?) more lines from this.

Jan 18 '15 07:01 kenji21

I guess @gmkumar2005 is taking about slightly different feature than initially proposed by @kenji21

As someone said some time ago: @gmkumar2005 wants CODE review tool not COMMIT review tool :) And this is way harder to make Codebrag being that kind of tool.

Regarding context, that's something we would like to have, but I'm afraid that current implementation of getting difs in both backend and frontend would need to be drastically changed. We'd like to work on this at some point, but it requires frontend part of diffing to be rewritten.

Jan 19 '15 08:01 mostr

Maybe tuning the number of lines before/after can be made via a parameter in config file ?

Jan 19 '15 08:01 kenji21

I like the idea of being able to customize the number of lines before and after as well.

Aug 04 '15 11:08 jaboc83

After using codebrag for a while I changed my opinion on this issue. In one of the project we have pretty large source files. Haven't been reviewed for quite long time. It has become critical for me to be able to see full file and add comments on lines which are not in the diff. Increasing number of lines in diff is a quick solution but does not solve the issue I described. If we consider GitHub as a reference what I found is they allow display of previous lines and next line but don't allow comments. GitHub restricted the comments to lines displayed in the diff. If possible codebrag should allow comments on every line of source code.

On 04-Aug-2015, at 17:12, Jake Moening [email protected] wrote:

I like the idea of being able to customize the number of lines before and after as well.

— Reply to this email directly or view it on GitHub.

Aug 04 '15 16:08 gmkumar2005

I like this idea. To begin with, I would love to see more no of lines. The next step would be to view the entire file.