Kentaro Hayashi

icon indicating a website link https://xdump.org/

icon company @clear-code icon location Saitama/Japan icon location Clear Code Inc. (@clear-code) A Fluentd LTS maintainer. Supporting enterprise with Fluentd, Firefox ESR, Chronos and so on.

Results 285 comments of Kentaro Hayashi

Detect fallback local loopback address correctly

@repeatedly sorry for missing another test case, could you review, please?

節単位でファイルを分割したい

> Re:VIEW的な対処法としては、章ファイルに #@mapfile(節ファイル) を並べておき、review-preproc または rake preproc を実行すれば章ファイルのところに更新された形で入る、ということを使うことになります（format.ja.md を参照してください）。でもrake preprocだといきなり変わっちゃうのであまり嬉しくないかも。 `rake preproc`だと`#@mapfile`する対象の節ファイルでさらに`#@mapfile()`していても大丈夫そうですね。 ありがとうございます。

WIP test: add drilldowns[LABEL].columns[NAME].stage test case without cache

I've expected that output of this case is different, but not. any idea?

WIP test: add drilldowns[LABEL].columns[NAME].stage test case without cache

> Could you try --drilldowns[LABEL].filter instead of --query? Could you explain what you mean precisely? @kou In other test case, we discussed that `--filter` is not worked expectedly for `stage`,...

WIP test: add drilldowns[LABEL].columns[NAME].stage test case without cache

> In other test case I means #678 as other test case.

WIP test: add drilldowns[LABEL].columns[NAME].stage test case without cache

Note that `filtered` stage is not supported yet. so this test always fails. And the following part is meaningless because query is already processed before drilldown. ``` --match_columns items \...

doc normalize: add missing explanation for flags

I'll review.

test: add columns[NAME].stage test case without cache

I tried `snippet_html()` but it causes an `constant is null` error.

test: add columns[NAME].stage test case without cache

Thanks. I've fixed test case. @kou

test: add columns[NAME].stage test case without cache

I've fixed test case to use `highlight_html()`. Now this test case is executed as expected.