Kentaro Hayashi comments

Results 285 comments of


                                            Kentaro Hayashi

Use zstandard for buffer compression

@ReillyBrogan PR is welcome!

`FileUtils.mkdir_p` function call inside `backup_chunk` does not copy file permissions (e.g. sticky bit) into middle directories in the path.

Thanks, @Simon-Janos Do you know whether this issue is assigned to CVE-*?

`FileUtils.mkdir_p` function call inside `backup_chunk` does not copy file permissions (e.g. sticky bit) into middle directories in the path.

To be clear, if `dir_permission` was specified (like the above example), is it not vulnerable?

crashes cause bad chunks that fail to send

FYI: since v1.2.0, https://github.com/fluent/fluentd/blob/master/CHANGELOG.md#release-v120---20180430 [output: Backup for broken chunks](https://github.com/fluent/fluentd/pull/1952) is supported. It may help you.

Detect wrong plugin naming which contains extra kind prefix

I'll simplify test case.

Detect wrong plugin naming which contains extra kind prefix

TODO: check plugin gemdir.

Detect wrong plugin naming which contains extra kind prefix

What is the good way to detect dummy plugin? Just idea: launch fluentd with `--gem-path ` and put dummy plugin for it. But Gem::Specification.find_all can't detect it. :thinking:

Detect wrong plugin naming which contains extra kind prefix

Even though launched via `assert_fluentd_fails_to_start` with --gemfile, it cause an error with " error: You seem to use `bundle exec` already." It seems that BUNDLE_BIN_PATH checked and exit there.

FIPS support in Fluentd

According to https://github.com/ruby/openssl/issues/603 and https://github.com/ruby/openssl/releases/tag/v3.2.0, all of FIPS support effort is not fully merged in v3.2.0, so need to wait newer ruby/openssl release. (e.g. https://github.com/ruby/openssl/pull/694 was fixed after v3.2.0) As...

http_server: Ready to support Async 2.0 gem

Hmm, GitHub "update branch" feature is not what I want. rebased manually.