Kelson

Results 4099 comments of Kelson

> > but to me we should not pass all these login info all over the function > > It's not my preferred solution either, but there's not much we...

unit test code should be excluded of code coverage. We fix that in the config yml file for codecov.

@Jaifroid Thank you! On my side my question would be: if confirmed why the CI (zimcheck) didn't detect this serious problem?

@Jaifroid I just have created a new ZIM https://farm.openzim.org/pipeline/4ddb96e7-c2c4-49e2-8d24-49a0d7c3fbf4 Probably the bug is still there... but for aure worth to check.

To me this kind of discussion is a kind of dejavu... but when that happened and what was the conclusion?!?!?

> Removed the bug label. HEAD is not implemented and not mandatory. Then it shoukd return https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/501, and this shoukd not trigger an error in Grafana.

@cho-m Thank you for your PR. CI was OK a month ago, I will have a look and try to fix them so we can test your PR properly.

@cho-m I have fixed a few things but we have a serious problem with the Windows CI. The CI for Windows does not pass for the moment on `main` either......

@veloman-yunkan @cho-m I can not merge this PR right now because it brakes the CI on Windows. From what I understand, I see only one way to solve this (and...

@cho-m Please > > From what I understand, I see only one way to solve this (and just ignoring Windows seems a dirty fix). > > Could do a version...