Kelson
@adamlamar is currently unavailable. @veloman-yunkan would you be able please to make the few small changes you have recommended so we can finally merge this essential (for kiwix-desktop 2.5.0) PR?
@veloman-yunkan Thank you very much for your polishing of @adamlamar work. Pretty sure is busy with something else for the moment. Let us wait a few days but then please...
I have fixed the Codefactor errors and will merge
> I think that this change needs a follow-up in the form of the equivalent of [kiwix/container-images#279](https://github.com/kiwix/container-images/pull/279) This is too unclear to me. Where should this package added?
@josephlewis42 Great, please join Slack #scraper channel! https://join.slack.com/t/kiwixoffline/shared_invite/zt-19s7tsi68-xlgHdmDr5c6MJ7uFmJuBkg
@benoit74 This issue seems to be still actual and I would like to confirm: * Why we have this piece of code changing the DOM * If we still need...
I can only agree with you, but not that easy to mockup MediaWiki with different configurations. That said we have an easy way to deploy MediaWiki with https://github.com/offspot/mediawiki-docker
@malik1004x Thank you for your fix which at a first look is OK to me. We will do a proper review. Does that mean that you use MWoffliner to scrape...
@malik1004x All great, please just update this PR with the rest of the code
@malik1004x Thank you very much. @audiodude is the code reviewer, but to me we should not pass all these login info all over the function, they should just be used...