Keith Mattix II

Results 443 comments of Keith Mattix II

The key with this approach is that it doesn't effect any metrics that aren't already broken. If you have a cluster named api.facebook.com the cluster_name stat tag is just going...

> @keithmattix with this, do we end up with the tag in the metrics containing the `;`? Or is it dropped as part of the extraction This PR is an...

> > > @keithmattix with this, do we end up with the tag in the metrics containing the `;`? Or is it dropped as part of the extraction > >...

> > > > > @keithmattix with this, do we end up with the tag in the metrics containing the `;`? Or is it dropped as part of the extraction...

/assign @kflynn @keithmattix

The code for the app server is here: https://github.com/istio/istio/tree/master/pkg/test/echo. A good first step would be to just move this code into a repo under kubernetes-sigs.

/reopen The above PRs don't actual change the ownership of the code or build the image

Ah I misunderstood the previous discussion then; thanks for the clarification!