gateway-api
gateway-api copied to clipboard
kubernetes-sigs
Move mesh test app into k8s org
I'd rather have this image owned by k8s/gateway-api infra so we can bundle versions of it with each release of our conformance tests. Can you create an issue to track following up on that? Shorter term can we at least use a pinned version of this image so a change in this image doesn't have an immediate impact on our conformance tests?
Originally posted by @robscott in https://github.com/kubernetes-sigs/gateway-api/pull/1878#discussion_r1154742350
@keithmattix: GitHub didn't allow me to assign the following users: t-eckert.
Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide
In response to this:
/assign @t-eckert
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
The code for the app server is here: https://github.com/istio/istio/tree/master/pkg/test/echo. A good first step would be to just move this code into a repo under kubernetes-sigs.
/reopen The above PRs don't actual change the ownership of the code or build the image
@keithmattix: Reopened this issue.
In response to this:
/reopen The above PRs don't actual change the ownership of the code or build the image
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@keithmattix I actually did intend to close this one as I was taking the text of the issue very literally:
I'd rather have this image owned by k8s/gateway-api infra so we can bundle versions of it with each release of our conformance tests. Can you create an issue to track following up on that? Shorter term can we at least use a pinned version of this image so a change in this image doesn't have an immediate impact on our conformance tests?
So at least from my perspective, the goal was to build an image from within Gateway API and push it to a k8s owned registry. We have accomplished both of those things, despite not actually moving the code into this repo. In my opinion duplicating the code here is not really helpful, the main goal was to ensure that we control the image and can publish updates/version however it works best for us.
I know the actual title of the issue seems to suggest some more broader action, but I don't think it's required, so will close this out. If we want to consider moving code over here maybe we should discuss that in a separate issue.
/close
Ah I misunderstood the previous discussion then; thanks for the clarification!
Recently came across this with https://github.com/istio/istio/issues/56400. I was not familiar with this dependency. IMO worth either bringing the image/code here and/or documenting how to build a new image if we need changes (in istio repo)
/reopen
@LiorLieberman: Reopened this issue.
In response to this:
Recently came across this with https://github.com/istio/istio/issues/56400. I was not familiar with this dependency. IMO worth either bringing the image/code here and/or documenting how to build a new image if we need changes (in istio repo)
/reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue as fresh with
/remove-lifecycle stale - Close this issue with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue as fresh with
/remove-lifecycle rotten - Close this issue with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Reopen this issue with
/reopen - Mark this issue as fresh with
/remove-lifecycle rotten - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close not-planned
@k8s-triage-robot: Closing this issue, marking it as "Not Planned".
In response to this:
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied- After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied- After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closedYou can:
- Reopen this issue with
/reopen- Mark this issue as fresh with
/remove-lifecycle rotten- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close not-planned
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.