Keith Mattix II

Results 443 comments of Keith Mattix II

I definitely like this approach better. Remind me: do we use this format elsewhere?

Yes good call; @kinolaev do you have the bandwidth to tackle the docs changes as well?

+1 - folks who are at least somewhat familiar with Istio may expect all the L7 stuff to exist once they finish installing. We need to help them through this...

Feel free to put this on the Istio wish-list for Envoy and I can try it get knocked out in the next couple of Envoy releases

Can we use stats tags/aggregation to create a high level metric?

I think this is probably fine in theory, but I'm worried in practice. Metadata exchange scenarios aren't very well tested from what I can tell, so I'm not sure how...

Interesting....yeah this feels like an envoy behavioral decision; I'll try and find time to investigate

I think I would feel comfortable approving if this is behind a feature flag. As @howardjohn mentioned, we've had a lot of breakage in this area of the code lately,...

> Note the disabling CRDs is a bit wonky as they are not helm templated. Let's just template them :p