Keith Cirkel

Results 519 comments of Keith Cirkel

Thank you so much @foolip for the helpful and thorough review! I've added some commits that address most of your comments I believe.

I've got about half way through your new commentary, but I'll tackle the rest later. I've pushed up what I have so far.

I think I've addressed all your commentary @foolip if you would kindly review again.

All of the above review comments have been addressed @foolip (including adding the assert), thanks again and as always. I'll go add some WPTs for `currentTarget` in the meantime.

@mfreed7 I believe we're discussing it in the APAC friendly WHATNOT session in around 12 hours time.

This looks like a good idea to me, and this is a bit of a sticking point around form validation; there isn't a great way to correctly suppress the browser...

Looks like `showPopovers()` invocation of `topmost popover ancestor` needs to be given `true`.

FWIW this is now merged in Gecko: https://phabricator.services.mozilla.com/D200686.

Webkit bug: https://bugs.webkit.org/show_bug.cgi?id=269928

I'm not sure how much weight my opinion carries but I am concerned we're conflating two quite separate things; `::tooltip` is for styling of the thing that `title=` produces, and...