Keith Cirkel

Results 526 comments of Keith Cirkel

It's worth pointing out to those who are getting involved now, that there is only one real concrete use case for this. Currently dialogs will close given a device gesture...

@mayank99 this has been covered in [this comment](https://github.com/openui/open-ui/issues/834#issuecomment-1731935468), and [this one](https://github.com/openui/open-ui/issues/834#issuecomment-1731964515): > To be honest, a name using 'click' would not seem suitable to me, for reasons mentioned in the...

I'm supportive of this; dispatch events when we know we have a default for the target, or if there's a `-`. It's a great solution!

https://github.com/openui/open-ui/labels/agenda%2B To discuss this change again, especially with regard to custom action heuristics.

> When this gets revisited, ensuring we can support `#elementinternal.role="button"` or event just `role="button"` content would be amazing!! I believe the HTML spec takes an architectural hard line that aria...

Oh yeah this would be an amazing addition! GitHub maintains https://github.com/github/clipboard-copy-element which allows the following patterns: ```html Copy path src/index.js ``` ```html Copy ``` ```html Copy full URL Link text...

> ...unless and this might be an awful idea, what if the invoketarget was the invoker itself... If the heuristic was "for form control elements, the value is copied, for...

Specific naming requirements (https://github.com/openui/open-ui/issues/969#issuecomment-2251153158) mean that method names will not match their methods. I think as we define new actions we can consider specifying equivalent methods on a case-per-case basis.

> assumed the primary intent was for replacing `popovertarget` with a more generic attribute that would allow for the showing/hiding of other elements on the page This is part of...

> Would the mappings for some of these default actions be available in the browser's already. For example a button that triggers an element to go full screen already exists...