html
html copied to clipboard
whatwg
Allow top layer elements to be nested within popovers
This patch makes top layer elements, including the dialog element, to be nested inside of an open popover by not closing the popover when the new top layer element is opened. Without this patch, opening a modal dialog inside of a popover will make the page inert and make the dialog invisible. A separate PR for fullscreen will be made: https://github.com/whatwg/fullscreen/pull/237
Fixes https://github.com/whatwg/html/issues/9998
Implemented in chromium here: https://chromium-review.googlesource.com/c/chromium/src/+/5229300
- [ ] At least two implementers are interested (and none opposed):
- Chrome
- …
- [x] Tests are written and can be reviewed and commented upon at:
- https://github.com/web-platform-tests/wpt/pull/44146
- [ ] Implementation bugs are filed:
- Chromium: https://bugs.chromium.org/p/chromium/issues/detail?id=1520938
- Gecko: https://phabricator.services.mozilla.com/D200686
- WebKit: …
- [ ] MDN issue is filed: …
- [x] The top of this comment includes a clear commit message to use.
(See WHATWG Working Mode: Changes for more details.)
:boom: Error: Wattsi server error :boom:
PR Preview failed to build. (Last tried on Feb 9, 2024, 6:07 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
:rotating_light: Wattsi Server - Wattsi Server is the web service used to build the WHATWG HTML spec.
:link: Related URL
<!DOCTYPE html>
<html>
<head>
<meta name="viewport" content="width=device-width, initial-scale=1">
<meta name="robots" content="noindex">
<style>body,html{height:100%;margin:0}body{display:flex;align-items:center;justify-content:center;flex-direction:column;-webkit-font-smoothing:antialiased;text-rendering:optimizeLegibility}p{text-align:center;font-family:-apple-system,BlinkMacSystemFont,Segoe UI,Roboto,Oxygen,Ubuntu,Cantarell,Fira Sans,Droid Sans,Helvetica Neue,sans-serif;color:#000;font-size:14px;margin-top:-50px}p.code{font-size:24px;font-weight:500;border-bottom:1px solid #e0e1e2;padding:0 20px 15px}p.text{margin:0}a,a:visited{color:#aaa}</style>
</head>
<body>
<p class="code">
Error
</p>
<p class="text">
We encountered an error when trying to load your application and your page could not be served. Check the logs for your application in the App Platform dashboard.
</p>
<div style="display:none;">
<h1>
upstream_reset_before_response_started{connection_termination} (503 UC) </h1>
<p data-translate="connection_timed_out">App Platform failed to forward this request to the application.</p>
</div>
</body>
</html>
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.
Looks like showPopovers() invocation of topmost popover ancestor needs to be given true.
FWIW this is now merged in Gecko: https://phabricator.services.mozilla.com/D200686.
Looks like showPopovers() invocation of topmost popover ancestor needs to be given true.
done
Is anything missing from this PR? I'd like to ship this in Chrome 124, but that branches in a few weeks. I need the spec to land first.
Changes LGTM, now that we've resolved the thread. I can merge once all the checkboxes in the OP are filled out.
Nice, thanks! @josepharhar, mind updating the OP checkboxes?