Keith Smiley

Poor error with rule based toolchain capabilities

1

When trying to write a toolchain that supports --start-lib, my first attempt at trying to enable this feature was to apply that option to my linker because of this example:...

Provide `sysroot` with rules based toolchain, or deprecate it in bazel

3

Currently the new rules based CC toolchain implementation never sets `builtin_sysroot` https://github.com/bazelbuild/rules_cc/blob/d74915024017250e46d95e91a3defc34174effe0/cc/toolchains/impl/toolchain_config.bzl#L69-L89 and instead just treats sysroot as any other flag https://github.com/bazelbuild/rules_cc/blob/d74915024017250e46d95e91a3defc34174effe0/cc/toolchains/args/sysroot.bzl This diverges from the default CC toolchain behavior...

Rule based toolchains should expand `args` with `data`

2

I wrote a args rule like this: ```bzl cc_args( name = "asan_compile_args", actions = ["@rules_cc//cc/toolchains/actions:compile_actions"], args = [ "-fno-sanitize-recover=all", "-fsanitize=address", "-fsanitize-ignorelist=$(location //bazel/internal:asan-suppressions.txt)", ], data = [ "//bazel/internal:asan-suppressions.txt", ], ) ```...

Fix js_test nodejs toolchain exec_group

2

If you cross compile the js_test target, the nodejs toolchain needs to be configured for the test exec group. Depends on https://github.com/bazel-contrib/bazel_features/pull/112

[Bug]: `pip install` no longer works in 1.6.0 venvs

4

### What happened? ``` % which pip3 .../_main/bazel-out/k8-dbg/bin/utils/packaging/wheel/fix_wheel/fix_wheel.venv.runfiles/rules_python++python+python_3_12_x86_64-unknown-linux-gnu/bin/pip3 % pip3 install requests Defaulting to user installation because normal site-packages is not writeable ``` ### Version Development (host) and target OS/architectures:...

This lets us avoid trying to parse these values out of various arguments and instead we just get them through the environment.

Enable no_warn_duplicate_libraries for Xcode 15+

1

This is added in the repo rule if supported, but if your host is linux querying the system ld isn't valid. If you are using full Xcode we can just...