Keith Smiley

Jump through aliases with go to definition

1

It seems that by default the `definition` LSP call will (reasonably) jump to the common pattern where folks re-export symbols. I think in the common case I would prefer it...

Fix new nightly type mismatch

2

``` error[E0308]: mismatched types --> crates/starpls/src/event_loop.rs:348:45 | 348 | if self.req_queue.incoming.complete(resp.id.clone()).is_some() { | -------- ^^^^^^^^^^^^^^^ expected `&RequestId`, found `RequestId` | | | arguments to this method are incorrect | note:...

Otherwise the build fails with: ``` error[E0635]: unknown feature `stdsimd` --> ~/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/ahash-0.8.6/src/lib.rs:99:42 | 99 | #![cfg_attr(feature = "stdsimd", feature(stdsimd))] | ^^^^^^^ ``` https://users.rust-lang.org/t/error-e0635-unknown-feature-stdsimd/106445

Add `-resource-dir` override

1

We use a clang-tidy from the llvm releases binaries, previously we used clang-tidy built from LLVM itself with bazel. In both of these cases I've had to manually specify `-resource-dir`...

Enable cc_static_library by default

1

This has been experimental for a while without issues filed.

Use `includes` instead of `system_includes` for `includes` attr

8

Previously even though the attribute was named `includes` it was passed through the `system_includes` field of the compilation context. This resulted in toolchains passing these include paths with `-isystem`, which...

Fix cc_import.includes to work like the other rules

1

Fixes https://github.com/bazelbuild/bazel/issues/19182#issuecomment-2257733545 Fixes https://github.com/bazelbuild/bazel/issues/18866

Add cc_import.defines

1

Fixes https://github.com/bazelbuild/bazel/issues/19753