Keith Smiley

Results 1359 comments of Keith Smiley

Which part are you thinking about documenting specifically? Happy to accept PRs that improve the docs, the difference between `foo` and `foo.zip` surprises me as well, that might be worth...

likely is but that PR was very stale was all

Documenting this would be great, I don't think others are required

Yep I think they are needed for anything on device

We just hit this case with xctestrunner 0.2.7. Our log doesn't add much here: ``` 2019-05-23 19:04:40,046 Will consider the test as test type xcuitest to run. 2019-05-23 19:04:40,121 Generating...

Are the dylibs produced from this valid? Looks to me like their install names are incorrect: ``` bazel-bin/Modules/Logger/libLogger.dylib: bazel-out/ios-x86_64-min11.0-applebin_ios-ios_x86_64-fastbuild-ST-7786d55448f4/bin/Modules/Logger/libLogger_bin (compatibility version 0.0.0, current version 0.0.0) ```

huh looks like the macos_dylib rule produces one with a similar name, but I don't think that's right? Doesn't that need to be `@loader_path/Frameworks/libFoo.dylib` or something similar?

It kinda seems like right now you can't use this how you might want by bundling a tree of dylibs into a ios_unit_test, in these cases it seems that you're...

I can't think of another example where a packaging rule can be directly depended on via `deps` like this, and I assume this is why apple_binary has a `dylibs` attr...

depends on https://github.com/bazelbuild/rules_apple/pull/1532