tulsi icon indicating copy to clipboard operation
tulsi copied to clipboard

Module names are incorrect for indexing targets

Open michaeleisel opened this issue 5 years ago • 5 comments
trafficstars

Indexing targets still need to have their normal module names or they won't build properly, but tulsi uses mangled module names with _idx at the start

michaeleisel avatar Aug 11 '20 18:08 michaeleisel

Did you see any particular improvements? This came up before but we didn't notice any major differences when testing, perhaps we missed something. Would just need to do something similar to how we handle tests.

DavidGoldman avatar Aug 11 '20 18:08 DavidGoldman

yeah just setting the module names to be what they would be with bazel makes sense

michaeleisel avatar Aug 11 '20 20:08 michaeleisel

@Keith Why was #23 closed? Is this no longer an issue?

tinder-maxwellelliott avatar Oct 20 '20 19:10 tinder-maxwellelliott

likely is but that PR was very stale was all

keith avatar Oct 20 '20 19:10 keith

Looks like this is more relevant in Xcode 13 as the module name is used to resolve the auto-import functionality

DavidGoldman avatar Jun 08 '21 17:06 DavidGoldman

Thanks for submitting this issue but this tool is being deprecated. Please checkout rules_xcodeproj for a more complete and maintained Xcode integration.

keith avatar Feb 15 '23 17:02 keith