Keith Smiley
Keith Smiley
I'm pretty sure we don't get values for these variables which is why I had to do this in the first place 🤔 https://github.com/bazelbuild/rules_foreign_cc/pull/767 did something change in bazel for...
Aren't there other downsides of setting that to False? I can't recall the behavior matrix but I remember hitting issues with this before https://github.com/bazelbuild/rules_swift/pull/502
> We are adding `ctx.configuration.default_shell_env` to `env`, so we should be good? IIRC the issue had something to do with the `--action_env=FOO` form of passing a var through, I think...
Example cleanup if we merge https://github.com/bazelbuild/rules_apple/pull/958
Many other rules require this field to be set. I've generally felt like they could have defaults in some cases too. But I wonder if for now we should make...
pretty sure this won't fail but it should
something weird about bash with trap and set -u
What version of rules_apple / apple_support are you using, sounds like you need to update apple_support
Yea I actually hadn't seen that flag before, seems fair to submit something upstream about removing it if it really is unused, but my bet is things are used internally,...
Or we could try to make that apply to iOS / macOS compiles as well