Justus Magin

Results 244 comments of Justus Magin

> Though not immediately sure why that's a problem maybe changing the order of definition helps? [`cleanup`](https://github.com/dask/distributed/blob/40c94201f188ef13ba4719e08812b5d299c7b0af/distributed/utils_test.py#L1930) is defined after [`loop`](https://github.com/dask/distributed/blob/40c94201f188ef13ba4719e08812b5d299c7b0af/distributed/utils_test.py#L145) at the moment (which should not be an issue...

I, Justus Magin, further consent for you, Julius Busecke, to change the xMIP license to Apache-2.0.

FYI the custom unit formats PR was merged into `pint` so now it should be possible to register `xclim.core.units.pint2cfunits` as `"cfunits"` or `"cf"` and get something like `f"{quantity:.3f#cfunits}"` to work...

it seems `complex128` has the same issue, so it might be good to check that as well?

we could probably have a nicer error message, the one from `numpy` might be a bit confusing: ```pytb ValueError: interpolation can only be 'linear', 'lower' 'higher', 'midpoint', or 'nearest' ```...

@shoyer: I asked about this in pytest-dev/pytest#8450, but it seems we are on our own here. The recommendation was to use inheritance, but that currently breaks `parametrize` (see the `pad`...

@Zac-HD, would you have any advice for something like this? Edit: [this](https://github.com/keewis/xarray/tree/duckarray-tests-hypothesis) is a initial draft using `hypothesis`

For more context, the main idea is to provide a generic and cheap way to check the compatibility of any duckarray (including nested duckarrays) with `xarray`'s interface. I settled on...

@shoyer, I finally found `pandas`' extension array test suite again, which divides the tests into groups and provides base classes for each of them. It then uses fixtures to parametrize...

ping @shoyer, I'm mostly done with cleaning up the code. @Zac-HD, could I ask for another review? I *think* I applied most of your suggestions but I'm sure I missed...