sparse icon indicating copy to clipboard operation
sparse copied to clipboard

Fix nanmean for complex arrays.

Open hameerabbasi opened this issue 3 years ago • 2 comments

Fixes #553

hameerabbasi avatar Aug 03 '22 19:08 hameerabbasi

Codecov Report

Merging #555 (bf24a24) into master (30b7172) will decrease coverage by 0.44%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #555      +/-   ##
==========================================
- Coverage   92.75%   92.30%   -0.45%     
==========================================
  Files          20       20              
  Lines        3120     3120              
==========================================
- Hits         2894     2880      -14     
- Misses        226      240      +14     

codecov[bot] avatar Aug 03 '22 19:08 codecov[bot]

it seems complex128 has the same issue, so it might be good to check that as well?

keewis avatar Aug 08 '22 15:08 keewis

it seems complex128 has the same issue, so it might be good to check that as well?

Thanks, done in https://github.com/pydata/sparse/pull/555/commits/4cdf8c0cbeb81eeb48bb01fe4963312875c52ba6.

hameerabbasi avatar Aug 17 '22 03:08 hameerabbasi