Keegan

Leverage Code Quality tooling

1

Consider using a static analysis / code quality tool, for example Metabob or Sonarcloud, and integrating it into the CI process for this repository. Will need to decide on tooling,...

Create documentation that shows how to collect log messages

2

It would be good to have documentation that shows how to collect logs from the IdentityModelEventSource. This could either be in the wiki or right in the readme

Add tests for different cultures to JwtPayloadTest

3

See #1468 and #1467 JwtPayloadTest should have additional tests to verify that parsing behavior is correct for different cultures/formats

MI doesn't work for environments that don't have a shell

3

### Microsoft.Identity.Web Library Microsoft.Identity.Web.Certificate ### Microsoft.Identity.Web version latest ### Web app Not Applicable ### Web API Not Applicable ### Token cache serialization Not Applicable ### Description See here: https://github.com/AzureAD/microsoft-identity-web/blob/master/src/Microsoft.Identity.Web.Certificate/KeyVaultCertificateLoader.cs#L49-L53 Azure.Identity...

UI Automation tests are unstable

1

### Microsoft.Identity.Web Library Microsoft.Identity.Web ### Microsoft.Identity.Web version NA ### Web app Not Applicable ### Web API Not Applicable ### Token cache serialization Not Applicable ### Description UI Automation tests fail...

# Use Base64.DecodeFromUtf8InPlace for base64 decode ## Description Base64.DecodeFromUtf8InPlace is SIMD aware. CPU: ~ -12% on token read time before: | Method | Mean | Error | StdDev | Median...

# Reduce memory in get cache key Still some more testing to be done to look at all the cases. Need to understand perf of non-typical cases better where multiple...

GetTokenAcquirer cannot set SendX5C

1

### Microsoft.Identity.Web Library Microsoft.Identity.Web ### Microsoft.Identity.Web version 2.19.0 ### Web app Not Applicable ### Web API Not Applicable ### Token cache serialization Not Applicable ### Description As a user of...

**Is your feature request related to a problem? Please describe.** It is better for an abstract class to not have default implementations that only throw. **Describe the solution you'd like**...

**Describe the solution you'd like** Use EnforceCodeStyleInBuild https://learn.microsoft.com/en-us/dotnet/core/project-sdk/msbuild-props#enforcecodestyleinbuild Longer term, should align on code style with dotnet libraries, for example: https://github.com/dotnet/sdk/blob/main/.editorconfig